netdev - Re: [PATCH] i40e: remove unneeded tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 May 2015 09:31:16 -0700
From:	Shannon Nelson <shannon.nelson@...el.com>
To:	Laurent Navet <laurent.navet@...il.com>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	matthew.vick@...el.com, john.ronciak@...el.com,
	mitch.a.williams@...el.com, intel-wired-lan@...ts.osuosl.org,
	netdev@...r.kernel.org, linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i40e: remove unneeded tests

On Tue, May 26, 2015 at 1:26 PM, Laurent Navet <laurent.navet@...il.com> wrote:
> The same code is executed regardless ret_code value, so these tests can
> be removed.
> Fix Coverity CID 1268789 and 1268791
>
> Signed-off-by: Laurent Navet <laurent.navet@...il.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_hmc.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_hmc.c
> index 9b987cc..eae4248 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_hmc.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.c
> @@ -298,8 +298,6 @@ i40e_status i40e_remove_sd_bp_new(struct i40e_hw *hw,
>                 goto exit;
>         }
>         ret_code = i40e_free_dma_mem(hw, &(sd_entry->u.bp.addr));
> -       if (ret_code)
> -               goto exit;
>  exit:
>         return ret_code;
>  }
> @@ -353,8 +351,6 @@ i40e_status i40e_remove_pd_page_new(struct i40e_hw *hw,
>         }
>         /* free memory here */
>         ret_code = i40e_free_dma_mem(hw, &(sd_entry->u.pd_table.pd_page_addr));
> -       if (ret_code)
> -               goto exit;
>  exit:
>         return ret_code;
>  }
> --

Thanks, Laurent, for noticing this.  You're right, this needs some
attention, but I think by rewriting these two functions a little we
can come up with an even better and simpler solution.  I'll be posting
a different patch soon.

sln
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html