[<prev] [next>] [day] [month] [year] [list]
Message-Id: <1432751825-40804-1-git-send-email-roopa@cumulusnetworks.com>
Date: Wed, 27 May 2015 11:37:03 -0700
From: Roopa Prabhu <roopa@...ulusnetworks.com>
To: ebiederm@...ssion.com
Cc: davem@...emloft.net, rshearma@...cade.com, netdev@...r.kernel.org,
vivek@...ulusnetworks.com
Subject: [PATCH net v2 0/2] mpls: fix route del errors on wrong scope and type
From: Roopa Prabhu <roopa@...ulusnetworks.com>
This patch fixes incorrect -EINVAL errors due to invalid
scope and type during mpls route deletes.
$ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1
$ip -f mpls route show
100 as to 200 via inet 10.1.1.2 dev swp1
$ip -f mpls route del 100 as 200 via inet 10.1.1.2 dev swp1
RTNETLINK answers: Invalid argument
$ip -f mpls route del 100
RTNETLINK answers: Invalid argument
After patch:
$ip -f mpls route show
100 as to 200 via inet 10.1.1.2 dev swp1
$ip -f mpls route del 100 as 200 via inet 10.1.1.2 dev swp1
$ip -f mpls route show
Reported-by: Vivek Venkataraman <vivek@...ulusnetworks.com>
Signed-off-by: Vivek Venkataraman <vivek@...ulusnetworks.com>
Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
v2: split the fix between iproute2 and kernel as suggested by
Eric Biederman
Roopa Prabhu (2):
iproute2: mpls: always set type as RTN_UNICAST for route
mpls: fix mpls route deletes to not check for route scope
net/mpls/af_mpls.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists