netdev - Re: [PATCH iproute2] enable transparent LFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 May 2015 12:07:26 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Mike Frysinger <vapier@...too.org>
Cc:	stephen.hemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] enable transparent LFS

On Tue, 26 May 2015 02:51:30 -0400
Mike Frysinger <vapier@...too.org> wrote:

> From: Mike Frysinger <vapier@...omium.org>
> 
> Make sure we use 64-bit filesystem functions everywhere.  This applies not
> only to being able to read large files (which generally doesn't apply to
> us), but also being able to simply stat them (as they might be using large
> inodes).
> 
> Signed-off-by: Mike Frysinger <vapier@...omium.org>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 35cacc4..9d35ef1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -32,6 +32,8 @@ ADDLIB+=mpls_ntop.o mpls_pton.o
>  CC = gcc
>  HOSTCC = gcc
>  DEFINES += -D_GNU_SOURCE
> +# Turn on transparent support for LFS
> +DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
>  CCOPTS = -O2
>  WFLAGS := -Wall -Wstrict-prototypes  -Wmissing-prototypes
>  WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2

I am okay with this, is something specific it fixes or is it just
general good practice?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html