netdev - Re: [net-next:master 200/201] net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150527.001938.461731083662455514.davem@davemloft.net>
Date:	Wed, 27 May 2015 00:19:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fengguang.wu@...el.com
Cc:	edumazet@...gle.com, kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [net-next:master 200/201] net/ipv4/fib_trie.c:293:3: error:
 implicit declaration of function 'vfree'

From: kbuild test robot <fengguang.wu@...el.com>
Date: Wed, 27 May 2015 12:12:08 +0800

> All error/warnings:
> 
>    net/ipv4/fib_trie.c: In function '__node_free_rcu':
>>> net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>       vfree(n);
>       ^
>    net/ipv4/fib_trie.c: In function 'tnode_alloc':
>>> net/ipv4/fib_trie.c:312:3: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
>       return vzalloc(size);
>       ^
>>> net/ipv4/fib_trie.c:312:3: warning: return makes pointer from integer without a cast
>    cc1: some warnings being treated as errors

I'll take care of the fib_trie.c part:

commit ffa915d071ce4a05dcd866409df26513d25786f8
Author: David S. Miller <davem@...emloft.net>
Date:   Wed May 27 00:19:03 2015 -0400

    ipv4: Fix fib_trie.c build, missing linux/vmalloc.h include.
    
    We used to get this indirectly I supposed, but no longer do.
    
    Either way, an explicit include should have been done in the
    first place.
    
       net/ipv4/fib_trie.c: In function '__node_free_rcu':
    >> net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
          vfree(n);
          ^
       net/ipv4/fib_trie.c: In function 'tnode_alloc':
    >> net/ipv4/fib_trie.c:312:3: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
          return vzalloc(size);
          ^
    >> net/ipv4/fib_trie.c:312:3: warning: return makes pointer from integer without a cast
       cc1: some warnings being treated as errors
    
    Reported-by: kbuild test robot <fengguang.wu@...el.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index 5a5d9bd..01bce15 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -72,6 +72,7 @@
 #include <linux/list.h>
 #include <linux/slab.h>
 #include <linux/export.h>
+#include <linux/vmalloc.h>
 #include <net/net_namespace.h>
 #include <net/ip.h>
 #include <net/protocol.h>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html