netdev - Re: [PATCH net v2] xen/netback: Properly initialize credit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 May 2015 11:46:58 +0100
From:	Wei Liu <wei.liu2@...rix.com>
To:	Ross Lagerwall <ross.lagerwall@...rix.com>
CC:	<netdev@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	Wei Liu <wei.liu2@...rix.com>,
	Ian Campbell <ian.campbell@...rix.com>
Subject: Re: [PATCH net v2] xen/netback: Properly initialize credit_bytes

On Wed, May 27, 2015 at 11:44:32AM +0100, Ross Lagerwall wrote:
> Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue
> struct") introduced a regression when moving queue-specific data into
> the queue struct by failing to set the credit_bytes field. This
> prevented bandwidth limiting from working. Initialize the field as it
> was done before multiqueue support was added.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>

Acked-by: Wei Liu <wei.liu2@...rix.com>

> ---
> 
> Changed in v2: Fixed multiple-assignment.
> 
>  drivers/net/xen-netback/xenbus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
> index 3d8dbf5..fee0241 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -793,6 +793,7 @@ static void connect(struct backend_info *be)
>  			goto err;
>  		}
>  
> +		queue->credit_bytes = credit_bytes;
>  		queue->remaining_credit = credit_bytes;
>  		queue->credit_usec = credit_usec;
>  
> -- 
> 2.1.0
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html