netdev - Re: [PATCH net-next] bpf: allow BPF programs access skb->skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55676AFA.2030403@iogearbox.net>
Date:	Thu, 28 May 2015 21:22:34 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Alexei Starovoitov <ast@...mgrid.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bpf: allow BPF programs access skb->skb_iif
 and skb->dev->ifindex fields

On 05/28/2015 12:30 AM, Alexei Starovoitov wrote:
> classic BPF already exposes skb->dev->ifindex via SKF_AD_IFINDEX extension.
> Allow eBPF program to access it as well. Note that classic aborts execution
> of the program if 'skb->dev == NULL' (which is inconvenient for program
> writers), whereas eBPF returns zero in such case.

That's better, yep.

> Also expose the 'skb_iif' field, since programs triggered by redirected
> packet need to known the original interface index.
> Summary:
> __skb->ifindex         -> skb->dev->ifindex
> __skb->ingress_ifindex -> skb->skb_iif
>
> Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>

Acked-by: Daniel Borkmann <daniel@...earbox.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html