netdev - Re: [PATCH net-next V4 00/12] net/mlx5: ConnectX-4 100G Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcc5Pi1YfJBhZ4C9=xN8MrvL+qfddV7PLpZ=GfFa6hbmgCFsQ@mail.gmail.com>
Date:	Thu, 28 May 2015 12:23:36 +0300
From:	Amir Vadai <amirv@...lanox.com>
To:	David Miller <davem@...emloft.net>,
	Neil Horman <nhorman@...driver.com>
CC:	Ben Hutchings <ben@...adent.org.uk>,
	Or Gerlitz <gerlitz.or@...il.com>,
	netdev <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Tal Alon <talal@...lanox.com>,
	Achiad Shochat <achiad@...lanox.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>,
	Eric Dumazet <edumazet@...gle.com>, <tom@...bertland.com>,
	<jiri@...nulli.us>, Benjamin Poirier <bpoirier@...e.de>
Subject: Re: [PATCH net-next V4 00/12] net/mlx5: ConnectX-4 100G Ethernet driver

On Thu, May 28, 2015 at 11:52 AM, David Miller <davem@...emloft.net> wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Wed, 27 May 2015 20:57:37 +0100
>
>> How would an application tell the difference between an IRQ handler
>> being renamed, or being unregistered and re-registered under a different
>> name?  I'm fairly sure it can't tell.
>
> What do things like the userland IRQ balancer do?

Thanks to Neil Horman, userland scripts can get the irq number from
sysfs (/sys/bus/pci/devices/<device>/msi_irqs) which is not based on
the irq naming [1].
He also fixed irq_balancer [2] to use this API instead of being based
on those strings.

I will drop the irq renaming from the patchset. mlx5_core driver will
set generic irq names (since same irq's might service both Ethernet
and Infiniband), for example: mlx5_comp0@pci:0000:00:04.0.

Thanks,
Amir


[1] - kernel: da8d1c8 PCI/sysfs: add per pci device msi[x] irq listing (v5)
[2] - irq_balancer: 32a7757 Complete rework of how we detect and classify irqs
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html