netdev - Re: [PATCH net-next] neigh: Add missing rcu_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 May 2015 08:24:20 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	ying.xue@...driver.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] neigh: Add missing rcu_assign_pointer

On Thu, May 28, 2015 at 07:38:21AM -0700, Eric Dumazet wrote:
>
> A = B;  is perfectly fine since both A and B have the same __rcu
> attribute.
> 
> Sparse has no warning and should not.
> 
> root@...mazet-glaptop2:/usr/src/net# grep CONFIG_SPARSE_RCU_POINTER .config
> CONFIG_SPARSE_RCU_POINTER=y
> root@...mazet-glaptop2:/usr/src/net# make C=2 CF=-D__CHECK_ENDIAN__ net/core/neighbour.o
> ...
>   CHECK   net/core/neighbour.c

Indeed.  Thanks for pointing this out.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html