netdev - Re: Fw: [Bug 99161] New: 2.6.32.66 PPC Oops in tcp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 May 2015 17:59:13 +0200
From:	Willy Tarreau <w@....eu>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org, varenet@...isc-linux.org
Subject: Re: Fw: [Bug 99161] New: 2.6.32.66 PPC Oops in tcp_send_fin

Hi Eric,

On Fri, May 29, 2015 at 08:52:11AM -0700, Eric Dumazet wrote:
> On Fri, 2015-05-29 at 08:12 -0700, Stephen Hemminger wrote:
> > I think 2.6.32 is so old no one will care.

A few will still, but at least we must ensure the old guy finishes
his days nicely :-)

(...)
> I guess a backport went wrong.

Ah crap, sorry about that :-(

> Willy, please add following to your tree :
> 
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 5339f066234b..d1e2895bb63c 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -2136,7 +2136,7 @@ void tcp_send_fin(struct sock *sk)
>  	 */
>  	if (tskb && (tcp_send_head(sk) || tcp_memory_pressure)) {
>  coalesce:
> -		TCP_SKB_CB(skb)->flags |= TCPCB_FLAG_FIN;
> +		TCP_SKB_CB(tskb)->flags |= TCPCB_FLAG_FIN;
>  		TCP_SKB_CB(tskb)->end_seq++;
>  		tp->write_seq++;
>  	if (!tcp_send_head(sk)) {


Thanks Eric, I'm queuing this now.

Best regards,
Willy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html