netdev - Re: [PATCH net] xen: netback: read hotplug script once at start of day.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <556893BA.9030300@citrix.com>
Date:	Fri, 29 May 2015 17:28:42 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Ian Campbell <ian.campbell@...rix.com>, <xen-devel@...ts.xen.org>,
	<netdev@...r.kernel.org>
CC:	<wei.liu2@...rix.com>
Subject: Re: [PATCH net] xen: netback: read hotplug script once at start of
 day.

On 29/05/15 17:24, Ian Campbell wrote:
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -235,6 +235,7 @@ static int netback_remove(struct xenbus_device *dev)
>  		kobject_uevent(&dev->dev.kobj, KOBJ_OFFLINE);
>  		xen_unregister_watchers(be->vif);
>  		xenbus_rm(XBT_NIL, dev->nodename, "hotplug-status");
> +		kfree(be->vif->hotplug_script);

Should this kfree() be in xenvif_free()?

>  		xenvif_free(be->vif);
>  		be->vif = NULL;
>  	}

David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html