netdev - Re: [PATCH iproute2 v2] ss: Fix allocation of cong control alg name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1432939029.7456.95.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 29 May 2015 15:37:09 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Vadim Kochan <vadim4j@...il.com>, netdev@...r.kernel.org,
	daniel@...earbox.net, jose.r.guzman.mosqueda@...el.com
Subject: Re: [PATCH iproute2 v2] ss: Fix allocation of cong control alg name

On Fri, 2015-05-29 at 15:02 -0700, Stephen Hemminger wrote:


> Why not use strdupa? I handles arbitrary size?

I doubt this will please security guys.

RETURN VALUE
       The alloca() function returns a pointer to the beginning of the
allocated space.  If the allocation causes stack overflow, program
behavior is undefined.


Could we please stick with this 16 bytes value ?

I am confident we wont increase kernel side because of various backward
compatibility issues anyway.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html