netdev - Re: [PATCH] net: qlcnic: clean up sysfs error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150528.201412.1123479677671870378.davem@davemloft.net>
Date:	Thu, 28 May 2015 20:14:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vz@...ia.com
Cc:	shahed.shaikh@...gic.com, Dept-GELinuxNICDev@...gic.com,
	netdev@...r.kernel.org, rajesh.borundia@...gic.com
Subject: Re: [PATCH] net: qlcnic: clean up sysfs error codes

From: Vladimir Zapolskiy <vz@...ia.com>
Date: Fri, 29 May 2015 04:13:46 +0300

> Hello David,
> 
> On 29.05.2015 02:28, David Miller wrote:
>> From: Vladimir Zapolskiy <vz@...ia.com>
>> Date: Tue, 26 May 2015 03:49:45 +0300
>> 
>>> Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL
>>> and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the
>>> latter error code is arguable, but it is already used in the driver,
>>> so let it be here as well.
>>>
>>> Also remove always false (!buf) check on read(), the driver should
>>> not care if userspace gets its EFAULT or not.
>>>
>>> Signed-off-by: Vladimir Zapolskiy <vz@...ia.com>
>> 
>> Qlogic folks, I'm waiting for your promised feedback.
>> 
> 
> Rajesh reviewed and acked the change, thank you.
> 
> http://www.spinics.net/lists/netdev/msg331073.html

Thanks, I missed that, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html