netdev - Re: [PATCH net-next 3/3] net: systemport: Add a check for oversized packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXr9JHJ5X9FVTO-+-61HnFfsf=1dz7ObbbLxxDy9Zx=UbqhqQ@mail.gmail.com>
Date:	Thu, 28 May 2015 21:00:48 -0700
From:	Petri Gynther <pgynther@...gle.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next 3/3] net: systemport: Add a check for oversized packets

On Thu, May 28, 2015 at 3:24 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
> Occasionnaly we may get oversized packets from the hardware which exceed
> the nomimal 2KiB buffer size we allocate SKBs with. Add an early check
> which drops the packet to avoid invoking skb_over_panic() and move on to
> processing the next packet.
>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Reviewed-by: Petri Gynther <pgynther@...gle.com>

> ---
>  drivers/net/ethernet/broadcom/bcmsysport.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
> index d777b0db9e63..909ad7a0d480 100644
> --- a/drivers/net/ethernet/broadcom/bcmsysport.c
> +++ b/drivers/net/ethernet/broadcom/bcmsysport.c
> @@ -638,6 +638,14 @@ static unsigned int bcm_sysport_desc_rx(struct bcm_sysport_priv *priv,
>                           p_index, priv->rx_c_index, priv->rx_read_ptr,
>                           len, status);
>
> +               if (unlikely(len > RX_BUF_LENGTH)) {
> +                       netif_err(priv, rx_status, ndev, "oversized packet\n");
> +                       ndev->stats.rx_length_errors++;
> +                       ndev->stats.rx_errors++;
> +                       dev_kfree_skb_any(skb);
> +                       goto next;
> +               }
> +
>                 if (unlikely(!(status & DESC_EOP) || !(status & DESC_SOP))) {
>                         netif_err(priv, rx_status, ndev, "fragmented packet!\n");
>                         ndev->stats.rx_dropped++;
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html