netdev - Re: [PATCH net-next 4/4] net/mlx4_core: Make sure there are no pending async events when freeing CQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150530.232345.188813752279467836.davem@davemloft.net>
Date:	Sat, 30 May 2015 23:23:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	netdev@...r.kernel.org, matanb@...lanox.com, amirv@...lanox.com,
	talal@...lanox.com, idos@...lanox.com
Subject: Re: [PATCH net-next 4/4] net/mlx4_core: Make sure there are no
 pending async events when freeing CQ

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Thu, 28 May 2015 18:41:16 +0300

> @@ -369,6 +369,10 @@ void mlx4_cq_free(struct mlx4_dev *dev, struct mlx4_cq *cq)
>  		mlx4_warn(dev, "HW2SW_CQ failed (%d) for CQN %06x\n", err, cq->cqn);
>  
>  	synchronize_irq(priv->eq_table.eq[MLX4_CQ_TO_EQ_VECTOR(cq->vector)].irq);
> +	if (priv->eq_table.eq[MLX4_CQ_TO_EQ_VECTOR(cq->vector)].irq !=
> +	    priv->eq_table.eq[MLX4_EQ_ASYNC].irq)
> +		synchronize_irq(priv->eq_table.eq[MLX4_EQ_ASYNC].irq);
> +
>  
>  	spin_lock_irq(&cq_table->lock);
>  	radix_tree_delete(&cq_table->tree, cq->cqn);

I agree with Sergei that one empty line is sufficient here, don't make
it into two.

Please respin with this fixed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html