netdev - Re: [PATCH] neighbour: Add loglevel to printk statment in the function, neigh_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpV3tHjq-f1fHXH3kefmzThyU4uCQ3JjyqrVcdGpLFA5TA@mail.gmail.com>
Date:	Mon, 1 Jun 2015 12:01:58 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, jeff@...ix.org,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] neighbour: Add loglevel to printk statment in the
 function, neigh_add_timer

On Sun, May 31, 2015 at 9:13 PM, Nicholas Krause <xerofoify@...il.com> wrote:
> This makes the printk statement in the function, neigh_add_timer
> have a loglevel of KERN_CRIT in order to get printed with the
> dumping of the stack if a double timer add arises rather then
> get dumped into the syslog buffer file instead in order to
> allow developers to see why a stack dump has arisen.
>

Instead, why not just use a WARN_ON() or something like that?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html