netdev - Re: [PATCH] xen: netback: fix error printf format string.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150531.212618.1162284397803953903.davem@davemloft.net>
Date:	Sun, 31 May 2015 21:26:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ian.campbell@...rix.com
Cc:	xen-devel@...ts.xen.org, netdev@...r.kernel.org,
	wei.liu2@...rix.com
Subject: Re: [PATCH] xen: netback: fix error printf format string.

From: Ian Campbell <ian.campbell@...rix.com>
Date: Fri, 29 May 2015 17:22:04 +0100

> drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’:
> drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=]
>         (txreq.offset&~PAGE_MASK) + txreq.size);
>         ^
> 
> txreq.offset and .size are uint16_t fields.
> 
> Signed-off-by: Ian Campbell <ian.campbell@...rix.com>

This may get rid of the compiler warning on your machine, but it creates
one on mine:

drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’:
drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 5 has type ‘long unsigned int’ [-Wformat=]
        (txreq.offset&~PAGE_MASK) + txreq.size);
        ^

There is a type involved in this calculation which is arch
dependent, so you'll need to add a cast or something to
make this warning go away in all cases.