netdev - Re: [PATCH net-next v2] rocker: remove rocker parameter from functions that have rocker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Jun 2015 09:13:05 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	David Miller <davem@...emloft.net>
Cc:	simon.horman@...ronome.com, sfeldma@...il.com, jiri@...nulli.us,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] rocker: remove rocker parameter from
 functions that have rocker_port parameter

On Mon, Jun 01, 2015 at 04:05:56PM -0700, David Miller wrote:
> From: Simon Horman <simon.horman@...ronome.com>
> Date: Mon,  1 Jun 2015 13:25:04 +0900
> 
> > The rocker (switch) of a rocker_port may be trivially obtained from
> > the latter it seems cleaner not to pass the former to a function when
> > the latter is being passed anyway.
> > 
> > rocker_port_rx_proc() is omitted from this change as it is a hot path case.
> > 
> > Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> > Acked-by: Scott Feldman <sfeldma@...il.com>
> 
> Applied, thanks Simon.
> 
> Andy, DO NOT quote an entire patch just to ACK it.
> 
> That is, unless you think my time is better spend scrolling over and
> over across multiple copies of the same patch in the patchwork page
> while I review a change than it is spent actually reviewing people's
> work.

Will do.  Sorry for the noise and added work.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html