netdev - Re: [PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 02 Jun 2015 08:35:38 -0700
From:	roopa <roopa@...ulusnetworks.com>
To:	David Miller <davem@...emloft.net>
CC:	ebiederm@...ssion.com, rshearma@...cade.com,
	netdev@...r.kernel.org, vivek@...ulusnetworks.com
Subject: Re: [PATCH net v2 2/2] mpls: fix mpls route deletes to not check
 for route scope

On 6/1/15, 3:58 PM, David Miller wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> Date: Wed, 27 May 2015 11:37:05 -0700
>
>> -	if (rtm->rtm_scope != RT_SCOPE_UNIVERSE)
>> -		goto errout;
>> +	if (nlh->nlmsg_type != RTM_DELROUTE &&
>> +		rtm->rtm_scope != RT_SCOPE_UNIVERSE)
>> +			goto errout;
>> +
> This is not indented correctly.
>
> When a conditional spans multiple lines, two things must happen:
>
> 1) Each line must end with an operator rather than begin with one.
>
> 2) Each line starting with the second must start exactly at the
>     first column after the openning parenthesis of the conditional.
>     You must use the appropriate number of TAB then SPACE characters
>     necessary to achieve this.
>
sorry, missed this. I have resubmitted the series. thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html