netdev - Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <556D2B8C.9010108@huawei.com>
Date:	Tue, 2 Jun 2015 12:05:32 +0800
From:	Junling Zheng <zhengjunling@...wei.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	<lizefan@...wei.com>, <viro@...iv.linux.org.uk>,
	<davem@...emloft.net>, <xuhanbing@...wei.com>,
	<stable@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg
 and sendmsg

On 2015/6/2 9:21, Greg KH wrote:
> On Mon, Jun 01, 2015 at 09:28:00AM +0000, Junling Zheng wrote:
>> Hi, Greg:
>>
>> We found that after v3.10.73, recvmsg might return -EFAULT while -EINVAL
>> was expected.
> 
> That means I messed up and applied something I shouldn't have, right?
> 
> Can you use 'git bisect' to find the problem patch?  That's probably
> easier here, and then I can either revert it, or fix up a broken
> backport.
> 

The following is the log of 'git bisect' between v3.10.72 and v3.10.73:

z00238152@...ch-Test:linux-3.10>0$ git bisect log
git bisect start
# good: [7f4e64246049cef5ae1eca37eec1701a9477799e] Linux 3.10.72
git bisect good 7f4e64246049cef5ae1eca37eec1701a9477799e
# bad: [73895725a9401bd3454757fcfa7d691270ac7498] Linux 3.10.73
git bisect bad 73895725a9401bd3454757fcfa7d691270ac7498
# bad: [d8bee0e3abef10e73a003fdc7ec04ba313334007] workqueue: fix hang involving racing cancel[_delayed]_work_sync()'s for PREEMPT_NONE
git bisect bad d8bee0e3abef10e73a003fdc7ec04ba313334007
# bad: [281c9c3601b69f1fbc492beb5976e1e2685854de] net: compat: Update get_compat_msghdr() to match copy_msghdr_from_user() behaviour
git bisect bad 281c9c3601b69f1fbc492beb5976e1e2685854de
# good: [e2f572a9be3f00bcf470a918d9e53353bea9ef4c] net: sysctl_net_core: check SNDBUF and RCVBUF for min length
git bisect good e2f572a9be3f00bcf470a918d9e53353bea9ef4c
# good: [c77b9a724d8597e1151b1fcf013560188088dc8c] caif: fix MSG_OOB test in caif_seqpkt_recvmsg()
git bisect good c77b9a724d8597e1151b1fcf013560188088dc8c
# good: [742c1c523e50723c7b7ff0af228c6711f7d747dd] Revert "net: cx82310_eth: use common match macro"
git bisect good 742c1c523e50723c7b7ff0af228c6711f7d747dd
# good: [175ff19c37149c352e3b983a8d78add034aef36f] tcp: fix tcp fin memory accounting
git bisect good 175ff19c37149c352e3b983a8d78add034aef36f
# first bad commit: [281c9c3601b69f1fbc492beb5976e1e2685854de] net: compat: Update get_compat_msghdr() to match copy_msghdr_from_user() behaviour
z00238152@...ch-Test:linux-3.10>0$

So, the problem commit is 281c9c36 (net: compat: Update get_compat_msghdr() to match copy_msghdr_from_user() behaviour), which fixes db31c55a6fb2
and brings the get_compat_msghdr() in line with copy_msghdr_from_user().

Cheers,

Junling

> thanks,
> 
> greg k-h
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html