netdev - [BUG] be2net breaks when dma_alloc_coherent memory is not zeroed out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150602072205.GA16345@suse.de>
Date:	Tue, 2 Jun 2015 09:22:05 +0200
From:	Joerg Roedel <jroedel@...e.de>
To:	Sathya Perla <sathya.perla@...gotech.com>,
	Ajit Khaparde <ajit.khaparde@...gotech.com>,
	Padmanabh Ratnakar <padmanabh.ratnakar@...gotech.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@...gotech.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [BUG] be2net breaks when dma_alloc_coherent memory is not zeroed out

Hi,

yesterday I bisected an issue with one of my be2net adapters and AMD
IOMMU enabled. In 4.1-rc it suddenly broke and didn't initialize
anymore. It turned out that the be2net driver breaks when the memory
returned from dma_alloc_coherent is not zeroed out. I introduced that
change to the AMD IOMMU driver for v4.1, other DMA-API implementations
for x86 still zero out the memory.

The bug shows like this in dmesg:

 be2net 0000:02:00.0: FW config: function_mode=0x10003, function_caps=0x7
 be2net 0000:02:00.0: FW not responding
 be2net 0000:02:00.0: Unrecoverable Error detected in the adapter
 be2net 0000:02:00.0: Please reboot server to recover
 be2net 0000:02:00.0: UE: MPU bit set

or sometimes as:

 be2net 0000:02:00.1: Waiting for POST, 52s elapsed
 be2net 0000:02:00.1: Waiting for POST, 54s elapsed
 be2net 0000:02:00.1: Waiting for POST, 56s elapsed
 be2net 0000:02:00.1: Waiting for POST, 58s elapsed

But always the result is:

 be2net 0000:02:00.1: Emulex OneConnect(be3) initialization failed
 be2net: probe of 0000:02:00.1 failed with error -110

When the memory returned by dma_alloc_coherent is zeroed out everything
works fine.

But strictly speaking dma_alloc_coherent is not required to zero out the
memory, drivers need to call dma_zalloc_coherent when they need this. So
the behavior of the AMD IOMMU driver is correct.

Can you guys please have a look and remove the assumption that
dma_alloc_coherent returns initialized memory in the be2net driver? In
the future I'd like to optimize out this needless zeroing out of memory
from all IOMMU drivers.

Please let me know if you need further information or if I can help with
testing or anything.

Thanks,

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html