lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Jun 2015 11:15:22 +0100 From: Luis Henriques <luis.henriques@...onical.com> To: Junling Zheng <zhengjunling@...wei.com> Cc: Willy Tarreau <w@....eu>, Greg KH <gregkh@...uxfoundation.org>, David Miller <davem@...emloft.net>, lizefan@...wei.com, viro@...iv.linux.org.uk, xuhanbing@...wei.com, stable@...r.kernel.org, netdev@...r.kernel.org, Kamal Mostafa <kamal@...onical.com> Subject: Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg On Tue, Jun 02, 2015 at 03:05:57PM +0800, Junling Zheng wrote: > On 2015/6/2 14:52, Willy Tarreau wrote: > > On Tue, Jun 02, 2015 at 02:43:54PM +0800, Junling Zheng wrote: > >> On 2015/6/2 14:27, Greg KH wrote: > >>> On Mon, Jun 01, 2015 at 10:23:57PM -0700, David Miller wrote: > >>>> From: Junling Zheng <zhengjunling@...wei.com> > >>>> Date: Tue, 2 Jun 2015 12:05:32 +0800 > >>>> > >>>>> So, the problem commit is 281c9c36 (net: compat: Update > >>>>> get_compat_msghdr() to match copy_msghdr_from_user() behaviour), > >>>>> which fixes db31c55a6fb2 and brings the get_compat_msghdr() in line > >>>>> with copy_msghdr_from_user(). > >>>> > >>>> Upstream this got fixed by: > >>>> > >>>> 08adb7dabd4874cc5666b4490653b26534702ce0 > >>>> > >>>> So the part that makes us not unconditionally return -EFAULT needs > >>>> to be backported, and that's probably equivalent to the patch > >>>> your proposed which therefore should be applied. > >>> > >>> Ok, thanks, now applied. > >>> > >> > >> Maybe other stable version also needs this fix:) > > > > Yes, from what I'm seeing, at least 3.2 and 2.6.32 need it as well. > > > > Yeah, all other stable versions *except 3.19 and 4.0* may need this fix:) This seems to be correct. I am queuing this fix for the 3.16 kernel as well. Thank you! Cheers, -- Luís -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists