netdev - Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150603010908.GE30703@verge.net.au>
Date:	Wed, 3 Jun 2015 10:09:08 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, makita.toshiaki@....ntt.co.jp,
	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware
 accelerated vlan

On Mon, Jun 01, 2015 at 02:56:25PM -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Mon, 01 Jun 2015 07:12:37 -0700
> 
> > Can we ensure offload_base contains a sensible order of expected
> > types ?
> 
> This seemed easy enough to kill, so I pushed the following into net-next:
> 
> ====================
> [PATCH] net: Add priority to packet_offload objects.
> 
> When we scan a packet for GRO processing, we want to see the most
> common packet types in the front of the offload_base list.
> 
> So add a priority field so we can handle this properly.
> 
> IPv4/IPv6 get the highest priority with the implicit zero priority
> field.
> 
> Next comes ethernet with a priority of 10, and then we have the MPLS
> types with a priority of 15.

FWIW I have no objections to the priority assigned to MPLS.

> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> Suggested-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html