netdev - Re: [Intel-wired-lan] [PATCH] fm10k: Fix missing braces after if statement

Open Source and information security mailing list archives

Message-ID: <1433460464.1500.4.camel@intel.com>
Date:	Thu, 4 Jun 2015 23:28:09 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	"alexander.h.duyck@...hat.com" <alexander.h.duyck@...hat.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] fm10k: Fix missing braces after if
 statement

Acked-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks Alex.

Regards,
Jake

On Wed, 2015-06-03 at 18:53 -0700, Alexander Duyck wrote:
> While reviewing the code I noticed that one of the commits added an if
> statement followed by a for loop, but the if statement was missing the
> braces around the loop.  This change corrects the coding style error.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> ---
>  drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
> index 4b9d9f88af70..a9670e00cf03 100644
> --- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
> @@ -143,12 +143,13 @@ static void fm10k_get_strings(struct net_device *dev, u32 stringset, u8 *data)
>  			p += ETH_GSTRING_LEN;
>  		}
>  
> -		if (interface->hw.mac.type != fm10k_mac_vf)
> +		if (interface->hw.mac.type != fm10k_mac_vf) {
>  			for (i = 0; i < FM10K_PF_STATS_LEN; i++) {
>  				memcpy(p, fm10k_gstrings_pf_stats[i].stat_string,
>  				       ETH_GSTRING_LEN);
>  				p += ETH_GSTRING_LEN;
>  			}
> +		}
>  
>  		for (i = 0; i < interface->hw.mac.max_queues; i++) {
>  			sprintf(p, "tx_queue_%u_packets", i);
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...ts.osuosl.org
> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives