netdev - Re: virtio-net: why not always to set avail->flags to VRING_AVAIL_F_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k2vkuvg8.fsf@rustcorp.com.au>
Date:	Thu, 04 Jun 2015 10:43:43 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Linhaifeng <haifeng.lin@...wei.com>, netdev@...r.kernel.org
Cc:	virtualization@...ts.linux-foundation.org,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: virtio-net: why not always to set avail->flags to VRING_AVAIL_F_NO_INTERRUPT

Linhaifeng <haifeng.lin@...wei.com> writes:
> Hi,
>
> I'm a newbie and have a question about vring_new_virtqueue function.
>
> Why we set avail->flags to VRING_AVAIL_F_NO_INTERRUPT when no callbacks?
> I think we should set avail->flags to VRING_AVAIL_F_NO_INTERRUPT even if no callbacks.

Hi Linhaifeng,

        Not sure I understand your question, but I'll try to answer.

We don't set VRING_AVAIL_F_NO_INTERRUPT if there's a callback because we
want that callback called.  Otherwise callback will never be used.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html