netdev - Re: [PATCH net-next] tcp: double default TSQ output bytes limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433400714.1895.36.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 03 Jun 2015 23:51:54 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Wei Liu <wei.liu2@...rix.com>
Cc:	netdev@...r.kernel.org,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	George Dunlap <george.dunlap@...citrix.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next] tcp: double default TSQ output bytes limit

On Wed, 2015-06-03 at 11:10 +0100, Wei Liu wrote:
> Xen virtual network driver has higher latency than a physical NIC.
> Having only 128K as limit for TSQ introduced 30% regression in guest
> throughput.
> 
> This patch raises the limit to 256K. This reduces the regression to 8%.
> This buys us more time to work out a proper solution in the long run.
> 
> Signed-off-by: Wei Liu <wei.liu2@...rix.com>
> Cc: David Miller <davem@...emloft.net>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> ---
>  net/ipv4/tcp_output.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 190538a..eeb59be 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -50,8 +50,8 @@ int sysctl_tcp_retrans_collapse __read_mostly = 1;
>   */
>  int sysctl_tcp_workaround_signed_windows __read_mostly = 0;
>  
> -/* Default TSQ limit of two TSO segments */
> -int sysctl_tcp_limit_output_bytes __read_mostly = 131072;
> +/* Default TSQ limit of four TSO segments */
> +int sysctl_tcp_limit_output_bytes __read_mostly = 262144;
>  
>  /* This limits the percentage of the congestion window which we
>   * will allow a single TSO frame to consume.  Building TSO frames

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html