lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <201506041854.P4RWFNh9%fengguang.wu@intel.com>
Date:	Thu, 4 Jun 2015 18:01:55 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org
Subject: [net-next:master 264/272] net/core/filter.c:1429:2: note: in
 expansion of macro 'if'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   c39c4c6abb89d24454b63798ccbae12b538206a5
commit: 3896d655f4d491c67d669a15f275a39f713410f8 [264/272] bpf: introduce bpf_clone_redirect() helper
config: x86_64-randconfig-i0-0604 (attached as .config)
reproduce:
  git checkout 3896d655f4d491c67d669a15f275a39f713410f8
  # save the attached .config to linux build tree
  make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/module.h:9,
                    from net/core/filter.c:24:
   net/core/filter.c: In function 'bpf_clone_redirect':
   net/core/filter.c:1429:18: error: 'struct sk_buff' has no member named 'tc_verd'
     if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
                     ^
   include/linux/compiler.h:145:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^
>> net/core/filter.c:1429:2: note: in expansion of macro 'if'
     if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
     ^
>> include/uapi/linux/pkt_cls.h:16:31: note: in expansion of macro '_TC_MAKE32'
    #define _TC_GETVALUE(v,n,m) ((_TC_MAKE32(v) & _TC_MAKE32(m)) >> _TC_MAKE32(n))
                                  ^
   include/uapi/linux/pkt_cls.h:54:26: note: in expansion of macro '_TC_GETVALUE'
    #define G_TC_AT(x)       _TC_GETVALUE(x,S_TC_AT,M_TC_AT)
                             ^
   net/core/filter.c:1429:6: note: in expansion of macro 'G_TC_AT'
     if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
         ^
   net/core/filter.c:1429:18: error: 'struct sk_buff' has no member named 'tc_verd'
     if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
                     ^
   include/linux/compiler.h:145:40: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                                           ^
>> net/core/filter.c:1429:2: note: in expansion of macro 'if'
     if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
     ^
>> include/uapi/linux/pkt_cls.h:16:31: note: in expansion of macro '_TC_MAKE32'
    #define _TC_GETVALUE(v,n,m) ((_TC_MAKE32(v) & _TC_MAKE32(m)) >> _TC_MAKE32(n))
                                  ^
   include/uapi/linux/pkt_cls.h:54:26: note: in expansion of macro '_TC_GETVALUE'
    #define G_TC_AT(x)       _TC_GETVALUE(x,S_TC_AT,M_TC_AT)
                             ^
   net/core/filter.c:1429:6: note: in expansion of macro 'G_TC_AT'
     if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
         ^
   net/core/filter.c:1429:18: error: 'struct sk_buff' has no member named 'tc_verd'
     if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
                     ^
   include/linux/compiler.h:156:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^
>> net/core/filter.c:1429:2: note: in expansion of macro 'if'
     if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
     ^
>> include/uapi/linux/pkt_cls.h:16:31: note: in expansion of macro '_TC_MAKE32'
    #define _TC_GETVALUE(v,n,m) ((_TC_MAKE32(v) & _TC_MAKE32(m)) >> _TC_MAKE32(n))
                                  ^
   include/uapi/linux/pkt_cls.h:54:26: note: in expansion of macro '_TC_GETVALUE'
    #define G_TC_AT(x)       _TC_GETVALUE(x,S_TC_AT,M_TC_AT)
                             ^
   net/core/filter.c:1429:6: note: in expansion of macro 'G_TC_AT'
     if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
         ^

vim +/if +1429 net/core/filter.c

  1413	static u64 bpf_clone_redirect(u64 r1, u64 ifindex, u64 flags, u64 r4, u64 r5)
  1414	{
  1415		struct sk_buff *skb = (struct sk_buff *) (long) r1, *skb2;
  1416		struct net_device *dev;
  1417	
  1418		dev = dev_get_by_index_rcu(dev_net(skb->dev), ifindex);
  1419		if (unlikely(!dev))
  1420			return -EINVAL;
  1421	
  1422		if (unlikely(!(dev->flags & IFF_UP)))
  1423			return -EINVAL;
  1424	
  1425		skb2 = skb_clone(skb, GFP_ATOMIC);
  1426		if (unlikely(!skb2))
  1427			return -ENOMEM;
  1428	
> 1429		if (G_TC_AT(skb2->tc_verd) & AT_INGRESS)
  1430			skb_push(skb2, skb2->mac_len);
  1431	
  1432		if (BPF_IS_REDIRECT_INGRESS(flags))
  1433			return dev_forward_skb(dev, skb2);
  1434	
  1435		skb2->dev = dev;
  1436		return dev_queue_xmit(skb2);
  1437	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

View attachment ".config" of type "text/plain" (89826 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ