netdev - Re: [RFC PATCH net-next] tcp: add CDG congestion control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA++eYdtEpbvJFroDCJ1uduj2EQvH1XkkmRmPkuOaQf2mMe099g@mail.gmail.com>
Date:	Thu, 4 Jun 2015 17:41:03 +0200
From:	Kenneth Klette Jonassen <kennetkl@....uio.no>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Kenneth Klette Jonassen <kennetkl@....uio.no>,
	netdev <netdev@...r.kernel.org>,
	David Hayes <davihay@....uio.no>,
	Yuchung Cheng <ycheng@...gle.com>,
	Andreas Petlund <apetlund@...ula.no>,
	Dave Taht <dave.taht@...il.com>
Subject: Re: [RFC PATCH net-next] tcp: add CDG congestion control

>> +static  int window __read_mostly = 8;
>
> This is a (readonly) module parameter, but really is a constant (if you
> ever try to change it dynamically, bad things will happen in current
> code)
>
> const int window = 8;

It cannot be adjusted dynamically, but we can override the initial
window parameter when loading tcp_cdg as a module. Imho, this is a
good enough interface when considering that tuning CDG's parameters
are for special interest groups in the first place.

window, backoff_factor and backoff_beta are the most important knobs
that influence CDG's backoff behavior. We could remove window as a
parameter (make it constant), although that would make tuning it
rather tedious. We could also make window adjustable dynamically, but
I opt on waiting until someone needs this functionality before adding
the code. Or am I missing something?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html