netdev - Re: [PATCH] ethernet: micrel: use time_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA7r0fokoEnp9wb9taegXbXsUYiHtQj44naTnw2A7WZfxQWJ5Q@mail.gmail.com>
Date:	Fri, 5 Jun 2015 18:54:13 +0200
From:	Antonio Murdaca <antoniomurdaca@...il.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	Antonio Murdaca <antonio.murdaca@...il.com>, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	joe@...ches.com, akpm@...ux-foundation.org
Subject: Re: [PATCH] ethernet: micrel: use time_after_eq macro

I'll use that then and resubmit this patch

Thanks

2015-06-05 17:45 GMT+02:00 Julia Lawall <julia.lawall@...6.fr>:
> On Fri, 5 Jun 2015, Antonio Murdaca wrote:
>
>> use time_after_eq macro for time comparison
>>
>> Signed-off-by: Antonio Murdaca <antonio.murdaca@...il.com>
>> ---
>>  drivers/net/ethernet/micrel/ksz884x.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
>> index 48d2aec..9bce30c 100644
>> --- a/drivers/net/ethernet/micrel/ksz884x.c
>> +++ b/drivers/net/ethernet/micrel/ksz884x.c
>> @@ -6689,7 +6689,7 @@ static void mib_monitor(unsigned long ptr)
>>
>>       /* This is used to verify Wake-on-LAN is working. */
>>       if (hw_priv->pme_wait) {
>> -             if (hw_priv->pme_wait <= jiffies) {
>> +             if (time_after_eq(jiffies, hw_priv->pme_wait)) {
>
> There is also time_is_before_eq_jiffies.
>
> julia
>
>>                       hw_clr_wol_pme_status(&hw_priv->hw);
>>                       hw_priv->pme_wait = 0;
>>               }
>> --
>> 2.4.2
>>
>>



-- 
Antonio Murdaca
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html