netdev - Re: [PATCH] fib_trie: coding style: Use pointer after check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150607.234631.405943391269310676.davem@davemloft.net>
Date:	Sun, 07 Jun 2015 23:46:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	firogm@...il.com
Cc:	alexander.duyck@...il.com, eric.dumazet@...il.com, wharms@....de,
	julia.lawall@...6.fr, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	kernel-janitors@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] fib_trie: coding style: Use pointer after check

From: Firo Yang <firogm@...il.com>
Date: Mon,  8 Jun 2015 11:54:51 +0800

> As Alexander Duyck pointed out that:
> struct tnode {
>         ...
>         struct key_vector kv[1];
> }
> The kv[1] member of struct tnode is an arry that refernced by
> a null pointer will not crash the system, like this:
> struct tnode *p = NULL;
> struct key_vector *kv = p->kv;
> As such p->kv doesn't actually dereference anything, it is simply a
> means for getting the offset to the array from the pointer p.
> 
> This patch make the code more regular to avoid making people feel
> odd when they look at the code.
> 
> Signed-off-by: Firo Yang <firogm@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html