netdev - Re: [PATCH iproute2 resend] Fix changing tunnel remote and local address to any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <557557A7.5010004@6wind.com>
Date:	Mon, 08 Jun 2015 10:51:51 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Thadeu Lima de Souza Cascardo <cascardo@...hat.com>,
	netdev@...r.kernel.org
CC:	stephen@...workplumber.org
Subject: Re: [PATCH iproute2 resend] Fix changing tunnel remote and local
 address to any

Le 04/06/2015 14:01, Thadeu Lima de Souza Cascardo a écrit :
> If a tunnel is created with a local address, you can't change it to any.
>
>   # ip tunnel add tunl1 mode ipip remote 10.16.42.37 local 10.16.42.214 ttl 64
>   # ip tunnel show tunl1
>   tunl1: ip/ip  remote 10.16.42.37  local 10.16.42.214  ttl 64
>   # ip tunnel change tunl1 local any
>   # echo $?
>   0
>   # ip tunnel show tunl1
>   tunl1: ip/ip  remote 10.16.42.37  local 10.16.42.214  ttl 64
>
> It happens that parse_args zeroes ip_tunnel_parm, and when creating the
> tunnel, it is OK to leave it as is if the address is any. However, when
> changing the tunnel, the current parameters will be read from
> ip_tunnel_parm, and local and remote address won't be zeroes anymore, so
> it needs to be explicitly set to any.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...hat.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html