netdev - Re: [PATCH v3] ARM: pxa: ssp: remove unnessary free for devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Jun 2015 17:42:53 +0800
From:	Firo Yang <firogm@...il.com>
To:	davem@...emloft.net
Cc:	alexander.duyck@...il.com, eric.dumazet@...il.com, wharms@....de,
	julia.lawall@...6.fr, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	kernel-janitors@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3] ARM: pxa: ssp: remove unnessary free for devm_xxx

Sorry, please, ignore this patch.
I send it to the wrong receiver.

On Mon, Jun 08, 2015 at 05:37:10PM +0800, Firo Yang wrote:
>A Coccinelle warning.
>It's not necessary to free memory allocated with devm_xxx
>and using these free functions maybe lead to a double free that
>will corrupt the resource subsys. So, I just remove them.
>
>Signed-off-by: Firo Yang <firogm@...il.com>
>---
>In "[PATCH] ARM: pxa: ssp: remove unnessary free for devm_xxx", 
>I forgot to remove an unused variable struct resource *res.
>
> arch/arm/plat-pxa/ssp.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
>diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
>index ad9529c..2b92a3b 100644
>--- a/arch/arm/plat-pxa/ssp.c
>+++ b/arch/arm/plat-pxa/ssp.c
>@@ -232,25 +232,16 @@ static int pxa_ssp_probe(struct platform_device *pdev)
> 
> static int pxa_ssp_remove(struct platform_device *pdev)
> {
>-	struct resource *res;
> 	struct ssp_device *ssp;
> 
> 	ssp = platform_get_drvdata(pdev);
> 	if (ssp == NULL)
> 		return -ENODEV;
> 
>-	iounmap(ssp->mmio_base);
>-
>-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>-	release_mem_region(res->start, resource_size(res));
>-
>-	clk_put(ssp->clk);
>-
> 	mutex_lock(&ssp_lock);
> 	list_del(&ssp->node);
> 	mutex_unlock(&ssp_lock);
> 
>-	kfree(ssp);
> 	return 0;
> }
> 
>-- 
>2.4.2
>

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html