netdev - Re: [PATCH net v2] bridge: disable softirqs around br_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 07 Jun 2015 19:45:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nikolay@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, wkok@...ulusnetworks.com,
	stephen@...workplumber.org
Subject: Re: [PATCH net v2] bridge: disable softirqs around br_fdb_update
 to avoid lockup

From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Date: Sat,  6 Jun 2015 06:49:00 -0700

> br_fdb_update() can be called in process context in the following way:
> br_fdb_add() -> __br_fdb_add() -> br_fdb_update() (if NTF_USE flag is set)
> so we need to disable softirqs because there are softirq users of the
> hash_lock. One easy way to reproduce this is to modify the bridge utility
> to set NTF_USE, enable stp and then set maxageing to a low value so
> br_fdb_cleanup() is called frequently and then just add new entries in
> a loop. This happens because br_fdb_cleanup() is called from timer/softirq
> context. The spin locks in br_fdb_update were _bh before commit f8ae737deea1
> ("[BRIDGE]: forwarding remove unneeded preempt and bh diasables")
> and at the time that commit was correct because br_fdb_update() couldn't be
> called from process context, but that changed after commit:
> 292d1398983f ("bridge: add NTF_USE support")
> Using local_bh_disable/enable around br_fdb_update() allows us to keep
> using the spin_lock/unlock in br_fdb_update for the fast-path.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> Fixes: 292d1398983f ("bridge: add NTF_USE support")
> ---
> v2: new patch, uses local_bh_disable/enable instead of _bh variant
>     of spinlocks to keep the fast-path optimization. Please drop
>     "bridge: use _bh spinlock variant for br_fdb_update to avoid lockup"
>     in favor of this one.

Ok, I accidently applied v1, so I reverted that and applied and queued
this one instead for -stable.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html