netdev - Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1433808766.29864.70.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 08 Jun 2015 17:12:46 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	sergei.shtylyov@...entembedded.com, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, devicetree@...r.kernel.org,
	galak@...eaurora.org, netdev@...r.kernel.org,
	richardcochran@...il.com, linux-sh@...r.kernel.org,
	mitsuhiro.kimura.kc@...esas.com
Subject: Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

On Mon, 2015-06-08 at 15:43 -0700, David Miller wrote:
> From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Date: Tue, 09 Jun 2015 01:41:12 +0300
> 
> > On 06/09/2015 01:19 AM, David Miller wrote:
> > 
> >> It's completely implemented in software, you don't need to do anything
> >> other than properly invoke napi_gro_receive().
> > 
> >    Not even set NETIF_F_GRO?
> 
> Yes, you have to set that by default for it to go.  Thankfully this is
> also "in software" ;-)


More precisely, drivers do not have to care about this flag.

They only have to call napi_gro_receive().

core networking sets GRO flag by default in register_netdevice() for all
network devices.


#define NETIF_F_SOFT_FEATURES   (NETIF_F_GSO | NETIF_F_GRO)

vi +6512 net/core/dev.c

        /* Transfer changeable features to wanted_features and enable
         * software offloads (GSO and GRO).
         */
        dev->hw_features |= NETIF_F_SOFT_FEATURES;
        dev->features |= NETIF_F_SOFT_FEATURES;



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html