netdev - Re: Weird DHCP related problems with net-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55774D23.1010508@gmail.com>
Date:	Tue, 09 Jun 2015 13:31:31 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Andrew Lunn <andrew@...n.ch>
CC:	Netdev <netdev@...r.kernel.org>, Scott Feldman <sfeldma@...il.com>,
	Jiri Pirko <jiri@...nulli.us>
Subject: Re: Weird DHCP related problems with net-next

Hi Andrew,

On 09/06/15 12:22, Andrew Lunn wrote:
> On Tue, Jun 09, 2015 at 11:54:50AM -0700, Florian Fainelli wrote:
>> Hi,
>>
>> I am observing a strange problem on net-next (not observed with net,
>> bisection in progress) where the initial DHCP configuration using
>> busybox's udhcpc is able to configure the local interface address and
>> DNS serer, but not the default gateway. Restarting udhcpc a second time
>> does not exhibit this problem.
> 
> Hi Florian
> 
> I've seen something similar, but different, again with DSA involved,
> on a WiFi Access point. I have debian, and i'm using isc dhcp. It gets
> an address, sets the address on the interface, but does not add the
> interface route to the routing table. Not sure about default route, i
> would have to go check that.

Interesting, did you also observe this with 'net', or just with 'net-next'?

Contrary to what I reported above, this is only an issue with
SYSTEMPORT/DSA/SF2, I could not reproduce this GENET or the Asix driver,
I was just conflating two different systems here.

My bisection seems to point at this commit:

58c2cb16b116d7feace621bd6b647bbabacfa225 ("switchdev: convert
fib_ipv4_add/del over to switchdev_port_obj_add/del")

And indeed, hacking a bit the kernel to remove the SWITCHDEV/DSA
dependencies to leave just DSA makes thing work again.

Scott, Jiri, any clues? I can instrument the kernel a bit more to help
find what is the problem here. Note that I am observing this on ARM
(Andrew probably is as well), where uninitialized stack variables are
potentially garbage.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html