netdev - Re: [PATCH net-next 19/19] bna: use netdev_* and dev_* instead of printk and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433968190.32331.32.camel@perches.com>
Date:	Wed, 10 Jun 2015 13:29:50 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ivan Vecera <ivecera@...hat.com>
Cc:	netdev@...r.kernel.org, rasesh.mody@...gic.com
Subject: Re: [PATCH net-next 19/19] bna: use netdev_* and dev_* instead of
 printk and pr_*

On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>

There should be some indication a few messages have
been deleted in the commit log and a reason why too.

> diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
[]
> @@ -965,10 +964,6 @@ bnad_cb_ethport_link_status(struct bnad *bnad,
>  						/*
>  						 * Force an immediate
>  						 * Transmit Schedule */
> -						printk(KERN_INFO "bna: %s %d "
> -						      "TXQ_STARTED\n",
> -						       bnad->netdev->name,
> -						       txq_id);

[]

> @@ -1057,8 +1051,6 @@ bnad_cb_tx_stall(struct bnad *bnad, struct bna_tx *tx)
>  		txq_id = tcb->id;
>  		clear_bit(BNAD_TXQ_TX_STARTED, &tcb->flags);
>  		netif_stop_subqueue(bnad->netdev, txq_id);
> -		printk(KERN_INFO "bna: %s %d TXQ_STOPPED\n",
> -			bnad->netdev->name, txq_id);

etc...


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html