netdev - Re: [PATCH v3] ipv6: Fix protocol resubmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2mw08kx7b.wl@gmail.com>
Date:	Wed, 10 Jun 2015 13:24:08 +0900
From:	Hajime Tazaki <thehajime@...il.com>
To:	davem@...emloft.net
Cc:	johunt@...mai.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org,
	sergei.shtylyov@...entembedded.com, tom@...bertland.com
Subject: Re: [PATCH v3] ipv6: Fix protocol resubmission


Hello Josh, Dave,

my mobile ipv6 test on libos failed with this commit.

This commit makes a destination option header handling (i.e.,
ipprot->handler == ipv6_destopt_rcv) failed since
ipv6_destopt_rcv() seems to return a positive value to
indicate to goto resubmission label.

I will look for more detail.

-- Hajime

At Mon, 08 Jun 2015 12:16:01 -0700 (PDT),
David Miller wrote:
> 
> From: Josh Hunt <johunt@...mai.com>
> Date: Mon,  8 Jun 2015 12:00:59 -0400
> 
> > UDP encapsulation is broken on IPv6. This is because the logic to resubmit
> > the nexthdr is inverted, checking for a ret value > 0 instead of < 0. Also,
> > the resubmit label is in the wrong position since we already get the
> > nexthdr value when performing decapsulation. In addition the skb pull is no
> > longer necessary either.
> > 
> > This changes the return value check to look for < 0, using it for the
> > nexthdr on the next iteration, and moves the resubmit label to the proper
> > location.
> > 
> > With these changes the v6 code now matches what we do in the v4 ip input
> > code wrt resubmitting when decapsulating.
> > 
> > Signed-off-by: Josh Hunt <johunt@...mai.com>
> 
> Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html