netdev - RE: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM2PR0301MB086380B3D89425345562F384F3BD0@DM2PR0301MB0863.namprd03.prod.outlook.com>
Date:	Wed, 10 Jun 2015 06:00:17 +0000
From:	Jianhua Xie <Jianhua.Xie@...escale.com>
To:	Madalin-Cristian Bucur <madalin.bucur@...escale.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet



> -----Original Message-----
> From: Linuxppc-dev [mailto:linuxppc-dev-
> bounces+jianhua.xie=freescale.com@...ts.ozlabs.org] On Behalf Of Madalin
> Bucur
> Sent: Wednesday, April 29, 2015 10:57 PM
> To: netdev@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org
> Cc: linux-kernel@...r.kernel.org; Bucur Madalin-Cristian-B32716
> Subject: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
> 
> This introduces the Freescale Data Path Acceleration Architecture
> (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,
> BMan, PAMU and FMan drivers to deliver Ethernet connectivity on
> the Freescale DPAA QorIQ platforms.
> 
Snip......

> +
> +	if (unlikely(dpa_xmit(priv, percpu_stats, queue_mapping, &fd) < 0))
> +		goto xmit_failed;
> +
> +	net_dev->trans_start = jiffies;

It is probably better to use netdev_queue->trans_start to instead of net_dev->trans_start on SMP.

Best Regards,
Jianhua

> +	return NETDEV_TX_OK;
> +
> +xmit_failed:
> +	if (fd.cmd & FM_FD_CMD_FCO) {
> +		(*countptr)--;
> +		dpa_fd_release(net_dev, &fd);
> +		percpu_stats->tx_errors++;
> +		return NETDEV_TX_OK;
> +	}
> +	_dpa_cleanup_tx_fd(priv, &fd);
> +	percpu_stats->tx_errors++;
> +	dev_kfree_skb(skb);
> +	return NETDEV_TX_OK;
> +}
> --
> 1.7.11.7
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...ts.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev