netdev - Re: [PATCH net-next 19/19] bna: use netdev_* and dev_* instead of printk and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Jun 2015 09:36:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ivan Vecera <ivecera@...hat.com>
Cc:	netdev@...r.kernel.org, rasesh.mody@...gic.com
Subject: Re: [PATCH net-next 19/19] bna: use netdev_* and dev_* instead of
 printk and pr_*

On Thu, 2015-06-11 at 11:43 +0200, Ivan Vecera wrote:
> On 06/10/2015 10:29 PM, Joe Perches wrote:
> > On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
> >> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> >
> > There should be some indication a few messages have
> > been deleted in the commit log and a reason why too.
> >
> >> diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
> > []
> >> @@ -965,10 +964,6 @@ bnad_cb_ethport_link_status(struct bnad *bnad,
> >>   						/*
> >>   						 * Force an immediate
> >>   						 * Transmit Schedule */
> >> -						printk(KERN_INFO "bna: %s %d "
> >> -						      "TXQ_STARTED\n",
> >> -						       bnad->netdev->name,
> >> -						       txq_id);
> >
> > []
> >
> >> @@ -1057,8 +1051,6 @@ bnad_cb_tx_stall(struct bnad *bnad, struct bna_tx *tx)
> >>   		txq_id = tcb->id;
> >>   		clear_bit(BNAD_TXQ_TX_STARTED, &tcb->flags);
> >>   		netif_stop_subqueue(bnad->netdev, txq_id);
> >> -		printk(KERN_INFO "bna: %s %d TXQ_STOPPED\n",
> >> -			bnad->netdev->name, txq_id);
> >
> > etc...
> >
> I'm sorry I have removed them as logging noise. IMHO it is not necessary 
> to log when .probe() and .remove() are called or when TxQ is started or 
> stopped.

I don't disagree at all, but it should be mentioned
in the commit message.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html