netdev - Re: [PATCH net-next] switchdev: change BUG_ON to WARN for attr set failure case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150611.162724.1330335369043090316.davem@davemloft.net>
Date:	Thu, 11 Jun 2015 16:27:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us, dsahern@...il.com
Subject: Re: [PATCH net-next] switchdev: change BUG_ON to WARN for attr set
 failure case

From: sfeldma@...il.com
Date: Thu, 11 Jun 2015 11:20:42 -0700

> From: Scott Feldman <sfeldma@...il.com>
> 
> This particular BUG_ON condition was checking for attr set err in the
> COMMIT phase, which isn't expected (it's a driver bug if PREPARE phase is
> OK but COMMIT fails).  But BUG_ON() is too strong for this case, so change
> to WARN().  BUG_ON() would be warranted if the system was corrupted beyond
> repair, but this is not the case here.
> 
> Signed-off-by: Scott Feldman <sfeldma@...il.com>

Applied, thanks Scott.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html