netdev - Re: [PATCH net-next 0/5] tcp: defer shinfo->gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150611.164502.578119775073363894.davem@davemloft.net>
Date:	Thu, 11 Jun 2015 16:45:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	edumazet@...gle.com
Cc:	netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com,
	edumazet@...il.com
Subject: Re: [PATCH net-next 0/5] tcp: defer shinfo->gso_size|type settings

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu, 11 Jun 2015 09:15:14 -0700

> We put shinfo->gso_segs in TCP_SKB_CB(skb) a while back for performance
> reasons.
> 
> This was in commit cd7d8498c9a5 ("tcp: change tcp_skb_pcount() location")
> 
> This patch series complete the job for gso_size and gso_type, so that
> we do not bring 2 extra cache lines in tcp write xmit fast path,
> and making tcp_init_tso_segs() simpler and faster.

Series applied, however long term I worry that using a u16 will not
work with TSO'd ipv6 jumbograms.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html