netdev - Re: [PATCH net-next] net/ethtool: Add current supported tunable options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150610.220725.1836894008272332422.davem@davemloft.net>
Date:	Wed, 10 Jun 2015 22:07:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hadarh@...lanox.com
Cc:	ben@...adent.org.uk, netdev@...r.kernel.org, amirv@...lanox.com,
	ogerlitz@...lanox.com, talal@...lanox.com, _govind@....com
Subject: Re: [PATCH net-next] net/ethtool: Add current supported tunable
 options

From: Hadar Hen Zion <hadarh@...lanox.com>
Date: Tue,  9 Jun 2015 18:29:54 +0300

> Add strings array of the current supported tunable options.
> 
> Signed-off-by: Hadar Hen Zion <hadarh@...lanox.com>
> Reviewed-by: Amir Vadai <amirv@...lanox.com>
> ---
>  include/uapi/linux/ethtool.h |  6 ++++++
>  net/core/ethtool.c           | 12 ++++++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index 0594933..90e4bff 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -215,6 +215,11 @@ enum tunable_id {
>  	ETHTOOL_ID_UNSPEC,
>  	ETHTOOL_RX_COPYBREAK,
>  	ETHTOOL_TX_COPYBREAK,
> +	/*
> +	 * Add your fresh new tubale attribute above and remember to update
> +	 * tunable_strings[] in net/core/ethtool.c
> +	 */
> +	ETHTOOL_TUNABLE_COUNT,
>  };
>  
>  enum tunable_type_id {

Please put two leading underscores in the name of this enumeration
to make it clear that it is an implementation internal value that
users should not try to use.  F.e. __ETHTOOL_TUNABLE_COUNT
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html