netdev - Re: [PATCH net-next] net: tcp: dctcp_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150610.232849.1817792758322372959.davem@davemloft.net>
Date:	Wed, 10 Jun 2015 23:28:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, daniel@...earbox.net, fw@...len.de
Subject: Re: [PATCH net-next] net: tcp: dctcp_update_alpha() fixes.

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 10 Jun 2015 22:11:17 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> dctcp_alpha can be read by from dctcp_get_info() without
> synchro, so use WRITE_ONCE() to prevent compiler from using
> dctcp_alpha as a temporary variable.
> 
> Also, playing with small dctcp_shift_g (like 1), can expose
> an overflow with 32bit values shifted 9 times before divide.
> 
> Use an u64 field to avoid this problem, and perform the divide
> only if acked_bytes_ecn is not zero.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

This looks fine, applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html