netdev - Re: [PATCH net-next v2] switchdev: fix BUG when port driver doesn't support set attr op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150612171732.GD588@gospo.home.greyhouse.net>
Date:	Fri, 12 Jun 2015 13:17:34 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us, bblanco@...mgrid.com
Subject: Re: [PATCH net-next v2] switchdev: fix BUG when port driver doesn't
 support set attr op

On Thu, Jun 11, 2015 at 08:19:01AM -0700, sfeldma@...il.com wrote:
> From: Scott Feldman <sfeldma@...il.com>
> 
> Fix a BUG_ON() where CONFIG_NET_SWITCHDEV is set but the driver for a
> bridged port does not support switchdev_port_attr_set op.  Don't BUG_ON()
> if -EOPNOTSUPP is returned.
> 
> Also change BUG_ON() to netdev_err since this is a normal error path and
> does not warrant the use of BUG_ON(), which is reserved for unrecoverable
> errs.
> 
> Signed-off-by: Scott Feldman <sfeldma@...il.com>
> Reported-by: Brenden Blanco <bblanco@...mgrid.com>

This is less aggressive -- good call.

Acked-by: Andy Gospodarek <gospo@...ulusnetworks.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html