[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAF2d9jgv-tmvvOHGmoyEYSmB5v-Bn93-T8kjMUk51miKSomECA@mail.gmail.com>
Date: Fri, 12 Jun 2015 10:53:02 -0700
From: Mahesh Bandewar <maheshb@...gle.com>
To: David Miller <davem@...emloft.net>
Cc: j.vosburgh@...il.com, andy@...yhouse.net, vfalico@...il.com,
nikolay@...hat.com, linux-netdev <netdev@...r.kernel.org>,
Eric Dumazet <edumazet@...gle.com>,
Maciej Żenczykowski <maze@...gle.com>
Subject: Re: [PATCH next v0] bonding: Display LACP info only to CAP_SYS_ADMIN
capable user
On Thu, Jun 11, 2015 at 3:22 PM, David Miller <davem@...emloft.net> wrote:
>
> From: Mahesh Bandewar <maheshb@...gle.com>
> Date: Wed, 10 Jun 2015 17:19:56 -0700
>
> > Actor and Partner details can be accessed via proc-fs and sys-fs
> > entries. These interfaces are world readable at this moment. The
> > earlier patch-series made the LACP communication secure to avoid
> > nuisance attack from within the same L2 domain but it did not
> > prevent "someone unprivileged" looking at that information on host
> > and perform the same act.
> >
> > This patch essentially avoids spitting those entries if the user
> > in question does not have enough privileges.
> >
> > Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
>
> I agree with Stephen Hemminger in that you should probably be using
> CAP_NET_ADMIN here.
Will change that into the next revision.
Thanks,
--mahesh..
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists