netdev - Re: [PATCH net-next] Fix Cavium Liquidio build related errors and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150612.191753.1337452083543935602.davem@davemloft.net>
Date:	Fri, 12 Jun 2015 19:17:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rvatsavayi@...iumnetworks.com
Cc:	netdev@...r.kernel.org, derek.chickles@...iumnetworks.com,
	satananda.burla@...iumnetworks.com,
	felix.manlunas@...iumnetworks.com,
	raghu.vatsavayi@...iumnetworks.com
Subject: Re: [PATCH net-next] Fix Cavium Liquidio build related errors and
 warnings

From: Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>
Date: Fri, 12 Jun 2015 18:11:50 -0700

> 1) Fixed following sparse warnings:
 ...
> 2) Fix build errors corresponding to vmalloc on linux-next 4.1.
> 3) Liquidio now supports 64 bit only, modified Kconfig accordingly.
> 4) Fix some code alignment issues based on kernel build warnings.
> 
> Signed-off-by: Derek Chickles <derek.chickles@...iumnetworks.com>
> Signed-off-by: Satanand Burla <satananda.burla@...iumnetworks.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@...iumnetworks.com>
> Signed-off-by: Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>

Applied, but I _seriously_ wish you didn't fix the readq/writeq stuff by
restricting the build of the driver to 64-bit.  That really kills build
test coverage.

Just provide an appropriate set of readq/writeq like other drivers do
by including either io-64-nonatomic-hi-lo.h or io-64-nonatomic-lo-hi.h

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html