netdev - [BUG ?] irda: via-ircc: condition with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1434192433-5934-1-git-send-email-hofrat@osadl.org>
Date:	Sat, 13 Jun 2015 12:47:13 +0200
From:	Nicholas Mc Guire <hofrat@...dl.org>
To:	Samuel Ortiz <samuel@...tiz.org>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [BUG ?] irda: via-ircc: condition with no effect

From: Nicholas Mc Guire <hofrat@...dl.org>                                      

scanning for trivial bug-patters with coccinelle spatches returned:
./drivers/net/irda/via-ircc.c:598
	WARNING: condition with no effect (if branch == else)

This code was added prior to the transition to git (Linux-2.6.12-rc2) so
I was not really able to track back what the intent was.

drivers/net/irda/via-ircc.c - line numbers from 4.1-rc7
598                 if (IsSIROn(iobase)) {  //sir
599                         EnGPIOtoRX2(iobase, OFF);                          
600                         WriteGIO(iobase, OFF);
601                         EnRX2(iobase, OFF);     //sir to rx2
602                 } else {        // fir mir
603                         EnGPIOtoRX2(iobase, OFF);
604                         WriteGIO(iobase, OFF);
605                         EnRX2(iobase, OFF);     //fir to rx
606                 }

Given the comments that indicate that the if/else case actually are
different this may be a bug - if not the comments might need fixing.

thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html