netdev - Re: [PATCH 06/11] IB/cma: Refactor RDMA IP CM private-data parsing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55801E5F.2000002@mellanox.com>
Date:	Tue, 16 Jun 2015 16:02:23 +0300
From:	Haggai Eran <haggaie@...lanox.com>
To:	"Hefty, Sean" <sean.hefty@...el.com>,
	Doug Ledford <dledford@...hat.com>
CC:	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Liran Liss <liranl@...lanox.com>,
	Guy Shapiro <guysh@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Yotam Kenneth <yotamke@...lanox.com>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Subject: Re: [PATCH 06/11] IB/cma: Refactor RDMA IP CM private-data parsing
 code

On 16/06/2015 01:33, Hefty, Sean wrote:
>> -static int cma_save_net_info(struct rdma_cm_id *id, struct rdma_cm_id
>> *listen_id,
>> -			     struct ib_cm_event *ib_event)
>> +static u16 cma_port_from_service_id(__be64 service_id)
>>  {
>> -	struct cma_hdr *hdr;
>> +	return be64_to_cpu(service_id);
>> +}
> 
> Nit - Does the compiler not complain about the cast from u64 to u16?
> 

Apparently it does, but only with W=3 (-Wconversion is included there).
W=3 produces about 6k warnings when compiling cma.c, so I don't usually
enable it.

I'll add a cast there to prevent the warning.

Haggai
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html