netdev - Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH6sp9PzTkNd88+ExRX1FTNNC=wC+jjOdL5urmtoyc5iz-pZTQ@mail.gmail.com>
Date:	Wed, 17 Jun 2015 10:30:18 +0200
From:	Frans Klaver <fransklaver@...il.com>
To:	Alexander Drozdov <al.drozdov@...il.com>
Cc:	Maninder Singh <maninder1.s@...sung.com>, davem@...emloft.net,
	willemb@...gle.com, dborkman@...hat.com,
	Al Viro <viro@...iv.linux.org.uk>, eyal.birger@...il.com,
	mst@...hat.com, netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	pankaj.m@...sung.com
Subject: Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON

On Wed, Jun 17, 2015 at 10:26 AM, Alexander Drozdov
<al.drozdov@...il.com> wrote:
> On Wed, 17 Jun 2015 09:36:11 +0200, Frans Klaver wrote:
>>
>> On Wed, Jun 17, 2015 at 6:36 AM, Maninder Singh <maninder1.s@...sung.com>
>> wrote:
>>>
>>> Use BUG_ON(condition) instead of if(condition)/BUG() .
>>>
>>> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
>>> Reviewed-by: Akhilesh Kumar <akhilesh.k@...sung.com>
>>> ---
>>>   net/packet/af_packet.c |    3 +--
>>>   1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
>>> index b5989c6..c91d405 100644
>>> --- a/net/packet/af_packet.c
>>> +++ b/net/packet/af_packet.c
>>> @@ -547,8 +547,7 @@ static void prb_setup_retire_blk_timer(struct
>>> packet_sock *po, int tx_ring)
>>>   {
>>>          struct tpacket_kbdq_core *pkc;
>>>
>>> -       if (tx_ring)
>>> -               BUG();
>>> +       BUG_ON(tx_ring);
>>>
>>>          pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) :
>>>                          GET_PBDQC_FROM_RB(&po->rx_ring);
>>
>>
>> I don't get this. We're not allowed to be using tx_ring, but we can
>> and do handle it? Does that still warrant a BUG() or BUG_ON()? It's
>> been in since the function introduction[0]. Can somebody explain?
>
>
> TPACKET_V3 doesn't support tx for now, so the function is actualy never
> called with non-zero tx_ring. I think there were plans to add the
> support. But retire timer for tx will not be needed anyway as it is
> up to user to fill the ring buffer.

Ah, that explains something. If retire timer is not going to be needed
for tx, wouldn't it be better to remove the whole tx_ring handling
from this function altogether, rather than changing the BUG()?

Thanks,
Frans
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html