netdev - Re: [PATCH v2 0/3] Fix Ethernet jumbo frames support for Armada 370 and 38x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150617172458.3e373b8a@free-electrons.com>
Date:	Wed, 17 Jun 2015 17:24:58 +0200
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	Simon Guinot <simon.guinot@...uanux.org>
Cc:	Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Vincent Donnefort <vdonnefort@...il.com>
Subject: Re: [PATCH v2 0/3] Fix Ethernet jumbo frames support for Armada 370
 and 38x

Dear Simon Guinot,

On Wed, 17 Jun 2015 15:19:19 +0200, Simon Guinot wrote:

> This patch series fixes the Ethernet jumbo frames support for the SoCs
> Armada 370, 380 and 385. Unlike Armada XP, the Ethernet controller for
> this SoCs don't support TCP/IP checksumming with a frame size larger
> than 1600 bytes.
> 
> This patches should be applied to the -stable kernels 3.8 and onwards.

You should add a Fixes: tag to each commit to indicate which commit is
being fixed by your patches.

Also, I was a bit surprised by your statement that Armada 38x is also
affected by the problem, since Armada 38x is more recent than Armada
XP. but indeed, according to the Armada 38x datasheet:

  IPv4 and TCP/UDP over IPv4/IPv6 checksum generation on transmit
  frames for standard Ethernet packet size

While the Armada XP datasheet says:

  Long frames transmission (including jumbo frames), with
  IPv4/v6/TCP/UDP checksum generation

So it seems like you're right about this!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html