netdev - Re: [PATCH net-next 2/3 v4] net: ipv4 sysctl option to ignore routes when nexthop link is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150618.032758.842689503494499354.davem@davemloft.net>
Date:	Thu, 18 Jun 2015 03:27:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gospo@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, ddutt@...ulusnetworks.com,
	sfeldma@...il.com, alexander.duyck@...il.com,
	hannes@...essinduktion.org, stephen@...workplumber.org
Subject: Re: [PATCH net-next 2/3 v4] net: ipv4 sysctl option to ignore
 routes when nexthop link is down

From: Andy Gospodarek <gospo@...ulusnetworks.com>
Date: Mon, 15 Jun 2015 12:33:20 -0400

> @@ -1035,12 +1036,18 @@ int fib_dump_info(struct sk_buff *skb, u32 portid, u32 seq, int event,
>  	    nla_put_in_addr(skb, RTA_PREFSRC, fi->fib_prefsrc))
>  		goto nla_put_failure;
>  	if (fi->fib_nhs == 1) {
> +		struct in_device *in_dev;
>  		if (fi->fib_nh->nh_gw &&
>  		    nla_put_in_addr(skb, RTA_GATEWAY, fi->fib_nh->nh_gw))
>  			goto nla_put_failure;

Please put an empty line between local variable declarations and code.

> @@ -1057,11 +1064,17 @@ int fib_dump_info(struct sk_buff *skb, u32 portid, u32 seq, int event,
>  			goto nla_put_failure;
>  
>  		for_nexthops(fi) {
> +			struct in_device *in_dev;
>  			rtnh = nla_reserve_nohdr(skb, sizeof(*rtnh));
>  			if (!rtnh)
>  				goto nla_put_failure;

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html